Skip to content

Conversation

andreasabel
Copy link
Contributor

@andreasabel andreasabel commented Jun 30, 2024

CI updated to cover GHC 8.0 - GHC 9.10.1.

@andreasabel
Copy link
Contributor Author

CI fails for GHC 8.0, not sure why:

Failed to build system-filepath-0.4.14. See the build log above for details.

setup: Unrecognised flags: lib:system-filepath

(Locally, I can build system-filepath-0.4.14 with GHC 8.0.2).

@andreasabel
Copy link
Contributor Author

I released system-filepath-0.4.14.1 merging this PR:

That fixed the CI problem!

@andreasabel
Copy link
Contributor Author

@stepcut : Please merge.

@andreasabel
Copy link
Contributor Author

@stepcut : Please merge.

Too late.

@stepcut stepcut merged commit d6e095a into Happstack:master Sep 1, 2025
6 of 13 checks passed
@stepcut
Copy link
Member

stepcut commented Sep 1, 2025

I dropped the dependencies on old-locale and transformers-compact. time 1.5 and transformers 0.4 were already in use by the time GHC 8.0.2 was released, so I think there is no need for those anymore.

I manually hacked the generated .yml file to remove the bit that was adding,

ghc-options: -Werror=incomplete-patterns -Werror=incomplete-uni-patterns

A better hack is to add something to cabal.haskell-ci. Probably this option,

https://github.com/haskell-CI/haskell-ci/blob/97f55f9ea1f482319dac4300322946bd3967b1f8/src/HaskellCI/Config/Grammar.hs#L168

A proper fix is to remove the incomplete patterns from happstack-server entirely. But doing that and checking that it does not affect performance is somewhat involved for potentially little to no gain.

@andreasabel
Copy link
Contributor Author

@stepcut: Thanks for the fixup. I didn't want to spend much time at that point because I wasn't sure to get your attention.

A better hack is to add something to cabal.haskell-ci. Probably this option,

I do this in a follow-up PR:

@andreasabel andreasabel deleted the ghc-9.10 branch September 1, 2025 09:38
@andreasabel andreasabel mentioned this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants